Use bincode's new API, add utility functions for safer use #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the deprecation warnings for the old `bincode::config()`, and adds wrapper utility functions that explicitly spells out whether serialization should use little or big endianness. Switching from `bincode::config()` to `bincode::options()` changed the default settings, which requires explicitly enabling `with_fixint_encoding` and `allow_trailing_bytes` to restore the old behaviour. Thanks @junderw for the investigative work and writing the code this is based on (mempool/electrs#34).
|
I verified DB compatibility by creating a database with 3a10582 (the current |
|
utACK 0739d50, code review |
junderw
pushed a commit
to junderw/electrs
that referenced
this pull request
May 1, 2024
…cast Feature: Configurable loop delay and bitcoind-only broadcast endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the deprecation warnings for the old
bincode::config(), and adds wrapper utility functions that explicitly spells out whether serialization should use little or big endianness.Switching from
bincode::config()tobincode::options()changed the default settings, which requires explicitly enablingwith_fixint_encodingandallow_trailing_bytesto restore the old behaviour.Thanks @junderw for the investigative work and writing the code this is based on (mempool/electrs#34).